gh-123067: Fix quadratic complexity in parsing cookies with backslashes #123075
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
added
type-security
…kslashes This fixes CVE-2024-7592.
serhiy-storchaka
force-pushed
the
http-coockies-optimize-re
branch
from
73e2aa9
to
04ac47b
Compare
picnixz
reviewed
Aug 16, 2024
Misc/NEWS.d/next/Library/2024-08-16-19-13-21.gh-issue-123067.Nx9O4R.rst
Outdated
Show resolved
Hide resolved
sethmlarson
approved these changes
Aug 16, 2024
There was a problem hiding this comment.
Ran the new tests with and without the changes, the approach looks good to me! Thanks @serhiy-storchaka! 🙏
picnixz
approved these changes
Aug 17, 2024
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11, 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2024
…values with backslashes (pythonGH-123075) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-123103 is a backport of this pull request to the 3.13 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2024
…values with backslashes (pythonGH-123075) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-123104 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2024
…values with backslashes (pythonGH-123075) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-123105 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2024
…values with backslashes (pythonGH-123075) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-123106 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2024
…values with backslashes (pythonGH-123075) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-123107 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Aug 17, 2024
…values with backslashes (pythonGH-123075) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-123108 is a backport of this pull request to the 3.8 branch. |
jeremyhylton
pushed a commit
to jeremyhylton/cpython
that referenced
this pull request
Aug 19, 2024
…values with backslashes (pythonGH-123075) This fixes CVE-2024-7592.
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
Aug 21, 2024
pythongh-123067: Fix quadratic complexity in parsing "-quoted cookie … …values with backslashes (pythonGH-123075) This fixes CVE-2024-7592.
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
Aug 22, 2024
pythongh-123067: Fix quadratic complexity in parsing "-quoted cookie … …values with backslashes (pythonGH-123075) This fixes CVE-2024-7592. Redo tests without a subtest Backport how RegEx stuff is handled to Python2
rickprice
added a commit
to ActiveState/cpython
that referenced
this pull request
Aug 22, 2024
pythongh-123067: Fix quadratic complexity in parsing "-quoted cookie … …values with backslashes (pythonGH-123075) This fixes CVE-2024-7592.
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…values with backslashes (pythonGH-123075) This fixes CVE-2024-7592.
Akendo
added a commit
to gardenlinux/package-python3.12
that referenced
this pull request
Aug 22, 2024
We create a patch from the PR on GitHub that address the vulerability. python/cpython#123075
hauntsaninja
pushed a commit
that referenced
this pull request
Aug 24, 2024
… values with backslashes (GH-123075) (#123103) gh-123067: Fix quadratic complexity in parsing "-quoted cookie values with backslashes (GH-123075) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
hauntsaninja
pushed a commit
that referenced
this pull request
Aug 24, 2024
… values with backslashes (GH-123075) (#123104) gh-123067: Fix quadratic complexity in parsing "-quoted cookie values with backslashes (GH-123075) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
…values with backslashes (GH-123075) (#123108) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
…values with backslashes (GH-123075) (#123107) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
… values with backslashes (GH-123075) (#123105) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
ambv
pushed a commit
that referenced
this pull request
Sep 4, 2024
… values with backslashes (GH-123075) (#123106) This fixes CVE-2024-7592. (cherry picked from commit 44e4583) Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes CVE-2024-7592.
http.cookies._unquote()#123067